Skip to content

Remove reqwest's native-tls dependency #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove reqwest's native-tls dependency #2261

wants to merge 1 commit into from

Conversation

@elichai
Copy link

@elichai elichai commented Sep 23, 2024 •
edited
Loading

Before:

cargo tree --no-default-features --features dist-client --target all -e normal -i openssl
openssl v0.10.64
└── native-tls v0.2.11
    ├── hyper-tls v0.6.0
    │   └── reqwest v0.12.5
    │       └── sccache v0.8.1 (/Users/elichai2/gits/sccache)
    ├── reqwest v0.12.5 (*)
    └── tokio-native-tls v0.3.1
        ├── hyper-tls v0.6.0 (*)
        └── reqwest v0.12.5 (*)

After:

cargo tree --no-default-features --features dist-client --target all -e normal -i openssl
warning: nothing to print.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.00%. Comparing base (0cc0c62) to head (3b559d8).
Report is 78 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2261       +/-   ##
===========================================
+ Coverage   30.91%   43.00%   +12.08%     
===========================================
  Files          53       54        +1     
  Lines       20112    20718      +606     
  Branches     9755     9636      -119     
===========================================
+ Hits         6217     8909     +2692     
- Misses       7922     8120      +198     
+ Partials     5973     3689     -2284

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre force-pushed the patch-1 branch 2 times, most recently from 472542e to 3b559d8 Compare October 2, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elichai @codecov-commenter